[NFCI][SYCL] More properties-related refactoring
#16126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
force-pushed
the
properties-more-refactoring
branch
from
abaddce to
71a55ff
Compare
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
force-pushed
the
properties-more-refactoring
branch
from
71a55ff to
39da438
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| return std::array<size_t, sizeof...(Dims) + 1>{Dim0, Dims...}[Dim]; | ||
| } | ||
|
|
||
| constexpr size_t size() const { return sizeof...(Dims) + 1; } |
Contributor
There was a problem hiding this comment.
This is public, but is not part of the extension. If we want to expose it, we need to add it to the extension too.
| return std::array<size_t, sizeof...(Dims) + 1>{Dim0, Dims...}[Dim]; | ||
| } | ||
|
|
||
| constexpr size_t size() const { return sizeof...(Dims) + 1; } |
Contributor
There was a problem hiding this comment.
Same as the previous comment.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
approved these changes
Nov 20, 2024
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detail::ConflictingPropertiesto acceptpropertieslist instead ofstd::tuplewith individual property valuesdetail::ValueOrDefaulttype-trait todetail::get_property_oras it seems a better interface (and can, in theory, work with runtime properties too)