[SYCL][Graph] Update UR tag for L0 kernel binary update #16154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Bensuo
commented
Nov 21, 2024
Bensuo
commented
- Fix potential implicit conversion from queue to command_graph when using dynamic command groups
- Remove XFAIL for dyn_cgf* tests on L0
- Fix dyn_cgf_accessor_spv test and add new prebuilt spirv binary for it
- Fix potential implicit conversion from queue to command_graph when using dynamic command groups - Remove XFAIL for dyn_cgf* tests on L0 - Fix dyn_cgf_accessor_spv test and add new prebuilt spirv binary for it
Contributor
|
I didn't want to disable all the L0 update testing, so didn't make this change earlier. But now could you add llvm/sycl/source/detail/device_impl.cpp Line 722 in 795ff19 aspect::ext_oneapi_graph
|
cperkinsintel
approved these changes
Nov 25, 2024
callumfare
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
callumfare
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
callumfare
approved these changes
Nov 27, 2024
Contributor
|
@intel/llvm-gatekeepers This is good to merge now, thanks Edit - sorry pinged to early, waiting on another CI run |
sommerlukas
pushed a commit
that referenced
this pull request
Dec 6, 2024
Adds the kernel binary update feature to the sycl graph specification. This introduces a new dynamic_command_group class which can be used to update the command-group function of a kernel nodes in graphs. Implemented in: * #16154 * #15700 --------- Co-authored-by: Ewan Crawford <[email protected]> Co-authored-by: Ben Tracy <[email protected]> Co-authored-by: Pablo Reble <[email protected]>
EwanC
pushed a commit
to reble/llvm
that referenced
this pull request
Jun 9, 2025
Since intel#16154 merged in November 2024 we have required a device to report the `UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_KERNEL_HANDLE` capability to support the `ext_oneapi_graph` aspect. Removing the comment was missed in that change, remove now since it caught my eye.
aelovikov-intel
pushed a commit
that referenced
this pull request
Jun 10, 2025
Since #16154 merged in November 2024 we have required a device to report the `UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_KERNEL_HANDLE` capability to support the `ext_oneapi_graph` aspect. Removing the comment was missed in that change, remove now since it caught my eye.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.