[SYCL][GRAPH] Add graph E2E tests which use free function extension #16159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyradical
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
keyradical
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
EwanC
reviewed
Nov 22, 2024
Contributor
EwanC
left a comment
EwanC
left a comment
There was a problem hiding this comment.
Couple of comments:
-
Add an entry to this part of the spec https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc#712-interaction-with-other-extensions to say we support the free function extension (and add yourself to the contributors section)
-
These tests all rely on a device having update support, however even without update support a device should still be able to use the free function extension in a static graph. Could we have a test for that? Probably only need 1 under
Inputswhich is then used inExplicitandRecordReplayvariants.
sycl/test-e2e/Graph/Update/FreeFunctionKernels/update_before_finalize.cpp
Outdated
Show resolved
Hide resolved
sycl/test-e2e/Graph/Update/FreeFunctionKernels/update_before_finalize.cpp
Outdated
Show resolved
Hide resolved
sycl/test-e2e/Graph/Update/FreeFunctionKernels/update_before_finalize.cpp
Outdated
Show resolved
Hide resolved
sycl/test-e2e/Graph/Update/FreeFunctionKernels/update_before_finalize.cpp
Outdated
Show resolved
Hide resolved
keyradical
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
keyradical
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
keyradical
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
keyradical
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
keyradical
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
keyradical
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
keyradical
force-pushed
the
konrad/AddGraphsWithFreeFunctionsTests
branch
from
0cad22a to
693fd38
Compare
keyradical
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
keyradical
force-pushed
the
konrad/AddGraphsWithFreeFunctionsTests
branch
from
693fd38 to
c852adf
Compare
keyradical
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
keyradical
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
EwanC
approved these changes
Nov 27, 2024
Contributor
EwanC
left a comment
EwanC
left a comment
There was a problem hiding this comment.
LGTM, remaining comments are nitpicking
sycl/test-e2e/Graph/Update/FreeFunctionKernels/free_function_kernels.hpp
Outdated
Show resolved
Hide resolved
sycl/test-e2e/Graph/Update/FreeFunctionKernels/free_function_kernels.hpp
Show resolved
Hide resolved
keyradical
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
keyradical
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@intel/llvm-gatekeepers could you merge this, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic parameters in SYCL Graphs should be used for now with free_function_kernels extension since then the order of kernel arguments is well defined.
The tests are a copy of few selected ones from
Graph/Updateand modified such that they use the extension. They live inGraph/Update/FreeFunctionKernels.Since the free function kernels are not yet implemented on CUDA, we should keep for now both copies of the tests (with and without free functions).