-
Notifications
You must be signed in to change notification settings - Fork 798
[SYCL] Fix no exception thrown for info::device::preferred_interop_user_sync and info::device::profile when the backend is not OpenCL
#16171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aelovikov-intel
merged 12 commits into
intel:sycl
from
dyniols:no_exception_thrown_for_interop_user_sync_or_device_profile
Nov 27, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
info::device::preferred_interop_user_sync and info::device::profileinfo::device::preferred_interop_user_sync and info::device::profile
…r_interop_user_sync_or_device_profile
info::device::preferred_interop_user_sync and info::device::profileinfo::device::preferred_interop_user_sync and info::device::profile when the backend is not OpenCL
Contributor
Author
|
@aelovikov-intel Could you review this PR? |
aelovikov-intel
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the SYCL 2020 specification, these two info descriptors are supposed to throw an exception when the backend is not OpenCL
info::device::preferred_interop_user_syncinfo::device::profilehttps://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#_device_information_descriptors