[SYCL][libclc][E2E] atomic work_item scope fallback #16172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Invocation case, that falls back to a coarser grained scope, to libclc atomic functions. This prevents hangs on AMD and crashes on NVIDIA when using atomic_ref functionality with work_item scope. Add a test which simply checks that the kernel does not crash when using atomic_ref with work_item scope. See issue: intel#16037
Seanst98
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Seanst98
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| try { | ||
|
|
||
| // Allocate device memory | ||
| int *data = sycl::malloc_device<int>(1, q); |
Contributor
There was a problem hiding this comment.
This needs to be free'ed properly.
Contributor
Author
There was a problem hiding this comment.
Good catch. Fixed.
Contributor
There was a problem hiding this comment.
Fixed.
That's why I dislike this part of the SYCL - no RAII for USM :(
Is that common for other e2e tests to "leak" USM on exceptions?
Seanst98
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
approved these changes
Nov 25, 2024
Seanst98
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Invocation case, that falls back to a coarser grained scope, to libclc atomic functions. This prevents hangs on AMD and crashes on NVIDIA when using atomic_ref functionality with work_item scope.
Add a test which simply checks that the kernel does not crash when using atomic_ref with work_item scope.
See issue: #16037