Skip to content

[SYCL][Test] Extend MultipleDevsCache test to check different order of devices #16175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2024
Merged

[SYCL][Test] Extend MultipleDevsCache test to check different order of devices #16175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions sycl/unittests/kernel-and-program/MultipleDevsCache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ static ur_result_t redefinedKernelRelease(void *) {
return UR_RESULT_SUCCESS;
}

class MultipleDeviceCacheTest : public ::testing::Test {
class MultipleDeviceCacheTest
: public testing::TestWithParam<std::array<size_t, NumDevices>> {
public:
MultipleDeviceCacheTest() : Mock{}, Plt{sycl::platform()} {}

Expand All @@ -109,17 +110,25 @@ class MultipleDeviceCacheTest : public ::testing::Test {

// Test that program is retained for each subset of the list of devices and that
// number of urKernelRelease calls is correct.
TEST_F(MultipleDeviceCacheTest, ProgramRetain) {
TEST_P(MultipleDeviceCacheTest, ProgramRetain) {
{
// Reset counters
RetainCounter = 0;
KernelReleaseCounter = 0;

std::vector<sycl::device> Devices = Plt.get_devices(info::device_type::gpu);
sycl::context Context(Devices);
sycl::queue Queue(Context, Devices[0]);
assert(Devices.size() == NumDevices &&
Context.get_devices().size() == NumDevices);

auto DeviceIndexes = GetParam();
auto KernelID = sycl::get_kernel_id<MultipleDevsCacheTestKernel>();
auto Bundle = sycl::get_kernel_bundle<sycl::bundle_state::input>(
Queue.get_context(), {KernelID});
Queue.get_context(),
{Devices[DeviceIndexes[0]], Devices[DeviceIndexes[1]],
Devices[DeviceIndexes[2]]},
{KernelID});
assert(Bundle.get_devices().size() == NumDevices);

// Internally we create a kernel_bundle for the device associated with the
Expand Down Expand Up @@ -178,3 +187,9 @@ TEST_F(MultipleDeviceCacheTest, ProgramRetain) {
// when handle is returned to the caller).
EXPECT_EQ(KernelReleaseCounter, 4) << "Expect 4 piKernelRelease calls";
}

INSTANTIATE_TEST_SUITE_P(
MultipleDeviceCacheInstance, MultipleDeviceCacheTest,
testing::Values(std::array<size_t, NumDevices>{0, 1, 2},
std::array<size_t, NumDevices>{1, 0, 2},
std::array<size_t, NumDevices>{2, 1, 0}));