[SYCL] Remove some OSUtil::* funcs from ABI under -fpreview-breaking-changes
#16177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng-changes` These are used internally in the DSO and don't need to be exposed outside. `OSUtil::getDirName` can be `static` will become static inside single TU under the `-fprivew-...` flag and `private` for the time being without the flag (to make sure no new uses will be added outside the TU). `OSUtil::getCurrentDSODir` is used in several TUs, so simply make it `__SYCL_DLL_LOCAL` to remove from exported symbols during the next ABI-breaking window.
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
|
PR looks good. Can we just update the description to have |
maarquitos14
approved these changes
Nov 26, 2024
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are used internally in the DSO and don't need to be exposed outside.
OSUtil::getDirNamewill becomestaticinside single TU under the-fpreview-breaking-changesflag andprivatefor the time being without the flag (to make sure no new uses will be added outside the TU).OSUtil::getCurrentDSODiris used in several TUs, so simply make it__SYCL_DLL_LOCALto remove from exported symbols during the next ABI-breaking window.