[SYCL] Support online_compiler::compile compiled with pre-C++11 ABI
#16179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
approved these changes
Nov 26, 2024
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
added a commit
that referenced
this pull request
Dec 4, 2024
…++11 ABI" (#16248) Reverts #16179 ``` template <source_language Lang> __SYCL_EXPORT std::vector<byte> online_compiler<Lang>::compile_impl( detail::string_view Src, detail::string_view DeviceStepping, const std::vector<detail::string_view> &Options) { ``` accesses `this->CompileToSPIRVHandle` which is laid out *after* `std::string` data member: ``` /// Target device stepping (implementation defined) std::string DeviceStepping; /// Handles to helper functions used by the implementation. void *CompileToSPIRVHandle = nullptr; ``` resulting in ABI incompatibility.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Dec 4, 2024
This is an updated version of intel#16179. Run-time ABI mismatch resulting in a segmentation fault was uncovered why enabling extra testing in intel#16235, this updated version fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.