[CI] Run Nightly E2E CI in pre-C++11 ABI mode #16235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We expect that our runtime library should work with user code compiled either way, but we don't be running double amount of testing in pre-commit/post-commit CI to verify that. Nightly looks like a reasonable choice to test this.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
I'm doing a test run at https://github.com/intel/llvm/actions/runs/12126461497 to ensure everything would pass. https://github.com/intel/llvm/actions/runs/12126279223 (it had extra changes to speed up testing and enable verbose output) verified that the option is passed properly. |
sarnex
approved these changes
Dec 2, 2024
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
approved these changes
Dec 3, 2024
Contributor
|
Just curious... SYCL requires at least C++17. What is the use-case for such an antique atrocity? 🤔 |
Contributor
Author
Even modern g++ in modern c++ modes support that. As for the reason, PyTorch, IIUC. |
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Dec 4, 2024
This is an updated version of intel#16179. Run-time ABI mismatch resulting in a segmentation fault was uncovered why enabling extra testing in intel#16235, this updated version fixes that.
Contributor
Author
|
There were fixes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expect that our runtime library should work with user code compiled either way, but we don't be running double amount of testing in pre-commit/post-commit CI to verify that. Nightly looks like a reasonable choice to test this.