Skip to content

Conversation

@sarnex
Copy link
Contributor

@sarnex sarnex commented Dec 3, 2024

dev-igc requites Ubuntu 24.04 now (because of glibc requirement). I need to update the dev-igc container creation/run to use Ubuntu 24.04, but first I need to add the base image that I can base the dev-igc image on, it can't be done in the same PR.

The changes to the install script are because of changes in 24.04, there should be no net effect.

Some of the Docker CI runs are going to fail here, but they will fail in every PR even without this change because of the new dev-igc requirement, we just need to make sure the new container I added here passes, which it did.

@sarnex sarnex marked this pull request as ready for review December 3, 2024 18:37
@sarnex sarnex requested a review from a team as a code owner December 3, 2024 18:37
Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Signed-off-by: Sarnie, Nick <[email protected]>
@sarnex sarnex requested a review from a team as a code owner December 3, 2024 18:57
@sarnex
Copy link
Contributor Author

sarnex commented Dec 3, 2024

@intel/dpcpp-doc-reviewers Can we get a quick review on the doc change here? Should be trivial, thanks.

@sarnex sarnex merged commit 74d4e9d into intel:sycl Dec 3, 2024
15 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants