[SYCL] Prefer _WIN32 over WIN32 in #if expressions
#16267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The former is defined by the toolchain while the latter is part of SDK, so using `_WIN32` is preferrable. The issue was exposed downstream due to recent changes from intel#16178 and intel#16194.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
approved these changes
Dec 4, 2024
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
EwanC
approved these changes
Dec 5, 2024
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Dec 16, 2024
I'm only able reproduce link error downstream for this API (and don't know what exactly is causing it), but the change is the same in nature as parts of intel#16178, intel#16194 and intel#16267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former is defined by the toolchain while the latter is part of SDK, so using
_WIN32is preferrable. The issue was exposed downstream due to recent changes from #16178 and #16194.