Skip to content

[SYCL] Add XFAIL trackers for several E2E tests marked with XFAIL #16287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aelovikov-intel merged 11 commits into from
Dec 6, 2024
Merged

[SYCL] Add XFAIL trackers for several E2E tests marked with XFAIL #16287

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8a231d1
Add XFAIL trackers for several tests
lbushi25 Dec 5, 2024
abd8fd3
Add XFAIL trackers for several tests
lbushi25 Dec 5, 2024
5edd0ad
Add XFAIL trackers for several more tests
lbushi25 Dec 5, 2024
dda50ca
Add XFAIL trackers for several more tests
lbushi25 Dec 5, 2024
87856a7
Reduce number of tests without XFAIL tracker
lbushi25 Dec 5, 2024
8d10473
Fix wrong tracker in span.cpp test
lbushi25 Dec 5, 2024
0f2daf2
Delete tests failing because of GSD-4509 issue
lbushi25 Dec 5, 2024
7bd5922
Remove XFAILs for hip nvidia plaform
lbushi25 Dec 6, 2024
b5471f8
Fix formatting
lbushi25 Dec 6, 2024
6df2d88
Fix typos and remove the tests from the list of improperly XFAIL-ed t…
lbushi25 Dec 6, 2024
357539d
Delete rogue file
lbushi25 Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sycl/test-e2e/Basic/buffer/reinterpret.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// RUN: %{run} %t.out
//
// XFAIL: level_zero&&gpu
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14430

//==---------- reinterpret.cpp --- SYCL buffer reinterpret basic test ------==//
//
Expand Down
2 changes: 2 additions & 0 deletions sycl/test-e2e/Basic/queue/queue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// RUN: %{run} %t.out
//
// XFAIL: hip_nvidia
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16197

//==--------------- queue.cpp - SYCL queue test ----------------------------==//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/Basic/queue/release.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// RUN: env SYCL_UR_TRACE=2 %{run} %t.out | FileCheck %s %if !windows %{--check-prefixes=CHECK-RELEASE%}
//
// XFAIL: hip_nvidia
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16197
Copy link
Contributor

@aelovikov-intel aelovikov-intel Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we remove XFAIL instead?

Copy link
Contributor Author

@lbushi25 lbushi25 Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we remove XFAIL instead?

Yes, this one slipped through the cracks. Fixed it now!


#include <sycl/detail/core.hpp>
int main() {
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/Basic/span.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
//
// Fails to release USM pointer on HIP for NVIDIA
// XFAIL: hip_nvidia
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14432
// REQUIRES: aspect-usm_shared_allocations
#include <numeric>

Expand Down
2 changes: 2 additions & 0 deletions sycl/test-e2e/Basic/stream/auto_flush.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// RUN: %{run} %t.out %if !gpu || linux %{ | FileCheck %s %}
//
// XFAIL: hip_nvidia
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16198

//==-------------- copy.cpp - SYCL stream obect auto flushing test ---------==//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
Expand Down
2 changes: 2 additions & 0 deletions sycl/test-e2e/DeprecatedFeatures/queue_old_interop.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
// hip_nvidia has problems constructing queues due to `No device of requested
// type available`.
// XFAIL: hip_nvidia
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16199

//==-------- queue_old_interop.cpp - SYCL queue OpenCL interop test --------==//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/DeviceCodeSplit/split-per-kernel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// RUN: %{run} %t.out
//
// XFAIL: hip_nvidia
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16201

#include <sycl/detail/core.hpp>
#include <sycl/kernel_bundle.hpp>
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/DeviceCodeSplit/split-per-source-main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// RUN: %{run} %t.out
//
// XFAIL: hip_nvidia
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16201

#include "Inputs/split-per-source.h"

Expand Down
2 changes: 2 additions & 0 deletions sycl/test-e2e/GroupAlgorithm/root_group.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// Fails with opencl non-cpu, enable when fixed.
// XFAIL: (opencl && !cpu && !accelerator)
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14641

// RUN: %{build} -I . -o %t.out %if any-device-is-cuda %{ -Xsycl-target-backend=nvptx64-nvidia-cuda --cuda-gpu-arch=sm_70 %}
// RUN: %{run} %t.out

Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/GroupLocalMemory/group_local_memory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// RUN: %{run} %t.out
//
// XFAIL: hip_nvidia
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16204

#include <sycl/detail/core.hpp>

Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/GroupLocalMemory/no_early_opt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// RUN: %{run} %t.out
//
// XFAIL: hip_nvidia
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16204

// The test checks that multiple calls to the same template instantiation of a
// group local memory function result in separate allocations, even with device
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/InvokeSimd/Feature/ImplicitSubgroup/invoke_simd_struct.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// TODO: Passing/returning structures via invoke_simd() API is not implemented
// in GPU driver yet. Enable the test when GPU RT supports it.
// XFAIL: gpu && run-mode
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14543
//
// RUN: %{build} -DIMPL_SUBGROUP -fno-sycl-device-code-split-esimd -Xclang -fsycl-allow-func-ptr -o %t.out
// RUN: env IGC_VCSaveStackCallLinkage=1 IGC_VCDirectCallsOnly=1 %{run} %t.out
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/InvokeSimd/Feature/invoke_simd_struct.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// TODO: Passing/returning structures via invoke_simd() API is not implemented
// in GPU driver yet. Enable the test when GPU RT supports it.
// XFAIL: gpu, run-mode
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14543
//
// RUN: %{build} -fno-sycl-device-code-split-esimd -Xclang -fsycl-allow-func-ptr -o %t.out
// RUN: env IGC_VCSaveStackCallLinkage=1 IGC_VCDirectCallsOnly=1 %{run} %t.out
Expand Down
15 changes: 0 additions & 15 deletions sycl/test-e2e/InvokeSimd/Spec/ImplicitSubgroup/tuple.cpp
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions sycl/test-e2e/InvokeSimd/Spec/ImplicitSubgroup/tuple_return.cpp
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions sycl/test-e2e/InvokeSimd/Spec/ImplicitSubgroup/tuple_vadd.cpp
View file
Open in desktop

This file was deleted.

147 changes: 0 additions & 147 deletions sycl/test-e2e/InvokeSimd/Spec/tuple.cpp
View file
Open in desktop

This file was deleted.

Loading
Loading