[SYCL] Update aspect propagation logic for virtual functions

[jzc]

For virtual functions the "construction" kernels that create objects that have function virtual functions but do not actually perform any virtual calls have the calls-indirectly attribute attached to them by the SYCLVirtualFunctionAnalysisPass. Because of this, aspect propagation will attach the aspects used by the sets referenced by the calls-indirectly to the construction kernel. However, these images should be able to be launched regardless of the optional kernel features used by their virtual functions, so this PR updates the aspect propagation logic to only propagate aspects to functions that have virtual calls.

// A "construction" kernel - it is not marked with `calls_indirectly`, does not perform any virtual calls,
// but creates an object with virtual functions
q.single_task([=] {
  // The kernel is not submitted with 'assume_indirect_calls_to' property and therefore
  // it is not considered to be using any of virtual member functions of 'Foo'.
  // This means that the object of 'Foo' can be successfully created by this
  // kernel, regardless of whether a target device supports 'fp64' aspect which
  // is used by 'Foo::foo'.
  // No exceptions are expected to be thrown.
  new (Storage) Foo;
});

[AlexeySachkov]

Suggested change

	bool hasVirtualCall = false;
	bool HasVirtualCall = false;

LLVM Coding Standards

[AlexeySachkov]

This is purely a FYI, LLVM has llvm::none_of which works with their ranges if you want to rewrite this into if (none_of(instructions(F), []() { multi-line lambda here }) return;. See STLExtras

[github-actions]

@intel/llvm-gatekeepers please consider merging

[sarnex]

Really old PR, I don't think this is intended to be merged, closing. Reopen if it should be merged.