[SYCL] Update aspect propagation logic for virtual functions #16288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For virtual functions the "construction" kernels that create objects that have function virtual functions but do not actually perform any virtual calls have the calls-indirectly attribute attached to them by the SYCLVirtualFunctionAnalysisPass. Because of this, aspect propagation will attach the aspects used by the sets referenced by the calls-indirectly to the construction kernel. However, these images should be able to be launched regardless of the optional kernel features used by their virtual functions, so this PR updates the aspect propagation logic to only propagate aspects to functions that have virtual calls.