-
Notifications
You must be signed in to change notification settings - Fork 798
[CI] New workflow for Nightly on sycl-rel #16297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We're working on setting a validation for sycl-rel branches. This PR introduces a new workflow to run Nightly on sycl-rel-* branches. GH actions allows to run scheduled workflows only if the workflow is on the default branch. So we have to checkout to the current rel branch for every job.
590261e to
c1a5be8
Compare
3706d5a to
7abb7b1
Compare
| extra_lit_opts: ${{ matrix.extra_lit_opts }} | ||
| reset_intel_gpu: ${{ matrix.reset_intel_gpu }} | ||
| ref: ${{ env.SYCL_REL_BRANCH }} | ||
| merge_ref: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any way we can share all of this because it seems really similar to existing code? can we make a reusable workflow or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By "share all of this" do you mean this job or the whole workflow? The code is really similar, but the matrix is a bit different from what we have in the normal Nightly. And it may be modified in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a high chance that we will also have different build configurations. For example, if we are going to release binaries from release branch, then we most likely don't want them to be built with assertions.
Even though there is a lot of similarity, I think that it is maybe ok. Going forward, we may have multiple release branches being active at the same time (due to long release schedule two may overlap a bit) and therefore we may have some unique things in this workflow to trigger it in an interesting way
|
@sarnex any other concerns? |
|
@intel/llvm-gatekeepers could you please merge this one? |
We're working on setting a validation for sycl-rel branches. This PR introduces a new workflow to run Nightly on sycl-rel-* branches.
GH actions allows to run scheduled workflows only if the workflow is on the default branch. So we have to checkout to the current rel branch for every job.