Skip to content

[SYCL][DeviceASAN] Fix AcceeChain to a matrix for bfloat16 #16323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martygrant merged 1 commit into from
Dec 11, 2024
Merged

[SYCL][DeviceASAN] Fix AcceeChain to a matrix for bfloat16 #16323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1623,7 +1623,8 @@ static TargetExtType *getTargetExtType(Type *Ty) {
// store float %1, ptr %call, align 4
// clang-format on
static bool isJointMatrixAccess(Value *V) {
if (auto *CI = dyn_cast<CallInst>(V)) {
auto *ActualV = V->stripInBoundsOffsets();
if (auto *CI = dyn_cast<CallInst>(ActualV)) {
for (Value *Op : CI->args()) {
if (auto *AI = dyn_cast<AllocaInst>(Op->stripInBoundsOffsets()))
if (auto *TargetTy = getTargetExtType(AI->getAllocatedType()))
Expand Down
6 changes: 4 additions & 2 deletions llvm/test/Instrumentation/AddressSanitizer/SPIRV/ignore_target_ext_type.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,13 @@ entry:
%a = alloca %"struct.sycl::_V1::ext::oneapi::experimental::matrix::joint_matrix", align 8
%0 = getelementptr inbounds %"struct.sycl::_V1::ext::oneapi::experimental::matrix::joint_matrix", ptr %a, i64 0, i32 0
%call.i35 = call spir_func ptr @_Z19__spirv_AccessChainIfN4sycl3_V13ext6oneapi12experimental6matrix9precision4tf32ELm8ELm8ELN5__spv9MatrixUseE0ELNS8_5Scope4FlagE3EEPT_PPNS8_28__spirv_CooperativeMatrixKHRIT0_XT4_EXT1_EXT2_EXT3_EEEm(ptr %0, i64 0)
%1 = getelementptr inbounds { i16 }, ptr %call.i35, i64 0, i32 0
; CHECK-NOT: call void @__asan_load
; CHECK-NOT: call void @__asan_store
%1 = load float, ptr %call.i35, align 4
%2 = load i16, ptr %1, align 4
%call.i42 = call spir_func ptr @_Z19__spirv_AccessChainIfN4sycl3_V13ext6oneapi12experimental6matrix9precision4tf32ELm8ELm8ELN5__spv9MatrixUseE0ELNS8_5Scope4FlagE3EEPT_PPNS8_28__spirv_CooperativeMatrixKHRIT0_XT4_EXT1_EXT2_EXT3_EEEm(ptr %0, i64 0)
store float %1, ptr %call.i42, align 4
%3 = getelementptr inbounds { i16 }, ptr %call.i42, i64 0, i32 0
store i16 %2, ptr %3, align 4
ret void
}

Expand Down
Loading