[SYCL][DRIVER] Add driver option for libdevice path #16329
Conversation
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| def fsycl_help : Flag<["-"], "fsycl-help">, Alias<fsycl_help_EQ>, | ||
| Flags<[NoXarchOption]>, AliasArgs<["all"]>, | ||
| HelpText<"Emit help information from all of the offline compilation tools">; | ||
| def fsycl_libdevice_path_EQ : Joined<["-"], "fsycl-libdevice-path=">, |
There was a problem hiding this comment.
Was this option scrutinized by the Options Working Group? Naming wise, this should closer match existing options. Something like -fsycl-device-lib-path=
There was a problem hiding this comment.
No, it wasn't. Tbf I wasn't really aware the working group existed, I went with -fsycl-libdevice-path because it's similar to -fsycl-libspirv-path, but I'm happy to change it as you deem necessary, is there any other reviewer we could ping in this PR to get their opinion? Or how should I go about submitting this to the Options Working Group?
There was a problem hiding this comment.
@PietroGhg, you can check internal wiki for more information. This should get enough eyes on the new option name.
PietroGhg
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
We ended up fixing this differently instead (#17408) and no longer need a new option. |
4 participants
Adds a
-fsycl-libdevice-paththat points to a non-default directory forlibdevice. This is particularly useful when cross-compiling for Native CPU.