Skip to content

Remove usage of deprecated getPointerTo() #16333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarnex merged 1 commit into from
Dec 12, 2024
Merged

Remove usage of deprecated getPointerTo() #16333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ class BinaryWrapper {
std::pair<Constant *, Constant *>
addStructArrayToModule(ArrayRef<Constant *> ArrayData, Type *ElemTy) {

auto *PtrTy = ElemTy->getPointerTo();
auto *PtrTy = llvm::PointerType::getUnqual(C);
Copy link
Contributor

@sarnex sarnex Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can any part of this go upstream? or is it all sycl specific?

Copy link
Contributor Author

@maarquitos14 maarquitos14 Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, ClangOffloadWrapper.cpp is not present upstream, is it?

Copy link
Contributor

@sarnex sarnex Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry i thought it was LinkerWrapper, my bad


if (ArrayData.size() == 0) {
auto *NullPtr = Constant::getNullValue(PtrTy);
Expand Down Expand Up @@ -917,8 +917,7 @@ class BinaryWrapper {
PropRegistry = MySymPropReader->getPropRegistry();
} else {
if (PropRegistryFile.empty()) {
auto *NullPtr =
Constant::getNullValue(getSyclPropSetTy()->getPointerTo());
auto *NullPtr = Constant::getNullValue(llvm::PointerType::getUnqual(C));
return std::pair<Constant *, Constant *>(NullPtr, NullPtr);
}
// load the property registry file
Expand Down
2 changes: 1 addition & 1 deletion llvm/lib/Frontend/Offloading/SYCLOffloadWrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ struct Wrapper {
std::pair<Constant *, Constant *>
addStructArrayToModule(ArrayRef<Constant *> ArrayData, Type *ElemTy) {
if (ArrayData.empty()) {
auto *PtrTy = ElemTy->getPointerTo();
auto *PtrTy = llvm::PointerType::getUnqual(ElemTy->getContext());
auto *NullPtr = Constant::getNullValue(PtrTy);
return std::make_pair(NullPtr, NullPtr);
}
Expand Down
Loading