[SYCL] Fix warnings in source/detail code #16334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| PersistentDeviceCodeCache::getCompiledKernelFromDisc( | ||
| const std::vector<device> &Devices, const std::string &BuildOptionsString, | ||
| const std::string SourceStr) { | ||
| const std::string &SourceStr) { |
Contributor
There was a problem hiding this comment.
nit: I think more idiomatic fix would be to use std::string_view.
Contributor
Author
There was a problem hiding this comment.
I am eliminating extra copy here, no intention to change types.
|
|
||
| if (URDevicesSet.size() > 1) { | ||
| // emplace all subsets of the current set of devices into the cache. | ||
| // Set of all devices is not included in the loop as it was already added |
Contributor
There was a problem hiding this comment.
I think this comment ("Set of all devices is not included...") needs to be moved to the line 832, if I understand the logic correctly.
| // emplace all subsets of the current set of devices into the cache. | ||
| // Set of all devices is not included in the loop as it was already added | ||
| // into the cache. | ||
| for (int Mask = 1; Mask < (1 << URDevicesSet.size()) - 1; ++Mask) { |
Contributor
There was a problem hiding this comment.
This code is much more maintainable than the new one. Also, if the problem is the "overflow" here, then it's inherent part of the problem. We'll have that many entries in the resulting set anyway (and likely OOM regardless).
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
aelovikov-intel
left a comment
aelovikov-intel
left a comment
There was a problem hiding this comment.
LGTM once the description is updated.
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
description is updated now, thanks |
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
approved these changes
Dec 13, 2024
KornevNikita
pushed a commit
that referenced
this pull request
Feb 25, 2025
Fixes places with copy instead of usage by reference or move. Protected potential but unlikely constant overflow with exception. --------- Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes places with copy instead of usage by reference or move.
Protected potential but unlikely constant overflow with exception.