Skip to content

Conversation

@sarnex
Copy link
Contributor

@sarnex sarnex commented Dec 16, 2024

No description provided.

Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
@bader
Copy link
Contributor

bader commented Dec 16, 2024

I would rather switch the pre-commit to keep the compilation with GCC compiler.

@sarnex
Copy link
Contributor Author

sarnex commented Dec 16, 2024

@bader we're using clang for precommit now, we switched recently because clang is way more sensitive with werror it seems and postcommit was breaking often when precommit passed

right now we have:
precommit: clang
postcomit: gcc
nightly: gcc

the idea is to change one of the gccs to oneapi, but i dont have a strong opinion of which and if we should reorder anything else

@bader
Copy link
Contributor

bader commented Dec 16, 2024

@bader we're using clang for precommit now, we switched recently because clang is way more sensitive with werror it seems and postcommit was breaking often when precommit passed

right now we have: precommit: clang postcomit: gcc nightly: gcc

the idea is to change one of the gccs to oneapi, but i dont have a strong opinion of which and if we should reorder anything else

oneAPI compiler is also clang-based. I don't expect significant difference between our clang and oneapi in the terms of produced warnings.

@sarnex
Copy link
Contributor Author

sarnex commented Dec 16, 2024

@bader sure, but sorry i dont understand what change you want me to make is :)

@sarnex
Copy link
Contributor Author

sarnex commented Dec 17, 2024

sure, but sorry i dont understand what change you want me to make is :)

@bader ping :)

@bader
Copy link
Contributor

bader commented Dec 17, 2024

Please, build the project with gcc either in pre-commit or post-commit CI job.

@sarnex
Copy link
Contributor Author

sarnex commented Dec 17, 2024

Got it, thanks.

Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
@sarnex
Copy link
Contributor Author

sarnex commented Jan 15, 2025

[](#16652)

@sarnex sarnex closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants