Skip to content

[SYCL] Don't export print_graph(std::string, bool) under -fpreview_breaking_changes #16390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 19, 2024
Merged

[SYCL] Don't export print_graph(std::string, bool) under -fpreview_breaking_changes #16390

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5739b0c
[SYCL] Don't export `print_graph(std::string, bool)` under `-fpreview…
aelovikov-intel Dec 16, 2024
d607867
Guard/dispatch the correct overload
aelovikov-intel Dec 17, 2024
05123e8
More fixes
aelovikov-intel Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions sycl/include/sycl/ext/oneapi/experimental/graph.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,14 @@ class __SYCL_EXPORT modifiable_command_graph
/// @param path The path to write the DOT file to.
/// @param verbose If true, print additional information about the nodes such
/// as kernel args or memory access where applicable.
#ifdef ___INTEL_PREVIEW_BREAKING_CHANGES
void modifiable_command_graph::print_graph(const std::string path,
bool verbose) const {
print_graph(sycl::detail::string_view{path}, verbose);
}
#else
void print_graph(const std::string path, bool verbose = false) const;
#endif

/// Get a list of all nodes contained in this graph.
std::vector<node> get_nodes() const;
Expand Down Expand Up @@ -387,6 +394,7 @@ class __SYCL_EXPORT modifiable_command_graph
std::shared_ptr<detail::graph_impl> impl;
};

#ifndef ___INTEL_PREVIEW_BREAKING_CHANGES
#ifdef __SYCL_GRAPH_IMPL_CPP
// Magic combination found by trial and error:
__SYCL_EXPORT
Expand All @@ -401,6 +409,7 @@ inline
bool verbose) const {
print_graph(sycl::detail::string_view{path}, verbose);
}
#endif

// Templateless executable command-graph base class.
class __SYCL_EXPORT executable_command_graph
Expand Down
Loading