Skip to content

Conversation

@srividya-sundaram
Copy link
Contributor

Set O0 as the default SYCL device optimization if -g is passed and optimization level is not provided explicitly.
Use of '-g' without any optimization-level option will turn off compiler optimizations similar to use of '-O0'.

@srividya-sundaram srividya-sundaram marked this pull request as ready for review December 18, 2024 23:36
@srividya-sundaram srividya-sundaram requested review from a team as code owners December 18, 2024 23:36
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esimd lgtm

Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks.

// CHECK-G-O2: sycl-post-link{{.*}} "-O2"
// CHECK-G-O2-NOT: "-O0"
// CHECK-G-O3: clang{{.*}} "-fsycl-is-device{{.*}}" "-O3"
// CHECK-G-O3: sycl-post-link{{.*}} "-O3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note - the -O2 to -O3 behavior is not in xmain, so some adjustments to the test will be needed when this is pulled down.

@srividya-sundaram
Copy link
Contributor Author

@intel/llvm-gatekeepers Hello, This is ready for merging. Thanks!

@sarnex sarnex merged commit 9a8613a into intel:sycl Dec 19, 2024
14 checks passed
sarnex pushed a commit that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants