Skip to content

[CI] Fix shared build on Ubuntu 24 #16595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 13, 2025
Merged

[CI] Fix shared build on Ubuntu 24 #16595

merged 11 commits into from
Jan 13, 2025

Conversation

uditagarwal97
Copy link
Contributor

fixes #16502

The problem is that zstd installed by default on Ubuntu 24 is built without -fPIC. This PR installs zstd on Ubuntu 24 docker container by building it from source.

@uditagarwal97 uditagarwal97 self-assigned this Jan 10, 2025
@uditagarwal97
Copy link
Contributor Author

Example of a successful shared lib build on Ubuntu 24: https://github.com/intel/llvm/actions/runs/12728630025/job/35479411381?pr=16595#step:8:19

@uditagarwal97 uditagarwal97 marked this pull request as ready for review January 12, 2025 00:21
@uditagarwal97 uditagarwal97 requested a review from a team as a code owner January 12, 2025 00:21
sarnex
sarnex reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix! minor comments

devops/containers/ubuntu2404_base.Dockerfile Outdated
COPY scripts/install_build_tools.sh /install.sh
RUN /install.sh

# Build zstd from sources with -fPIC flag.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we maybe add a link to the ubuntu bug report so we can check to remove this in the future?

Copy link
Contributor Author

@uditagarwal97 uditagarwal97 Jan 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the link to intel/llvm bug report instead: #15935
I'll likely have to open another bug report to Debian (as suggested here: https://bugs.launchpad.net/ubuntu/+source/libzstd/+bug/2086543/comments/3).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, thx

devops/scripts/build_zstd_1_5_6_ub24.sh
check_os

# Set USE_SUDO to true or false based on your preference
USE_SUDO=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're always using sudo can we just use it directly without this var?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a slight preference towards keeping this variable because it makes it a lot easier for me to test this script internally using podman (which requires not using sudo). I can remove this variable if you strongly feel so.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah no if it has a use thats totally fine, thx

@sarnex
Copy link
Contributor

sarnex commented Jan 13, 2025

igc dev fail not related

@sarnex sarnex merged commit 26bbc11 into sycl Jan 13, 2025
34 of 35 checks passed
@bader bader deleted the sycl-devops-pr/udit/ubu24_build_fix_zstd branch January 14, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarnex sarnex sarnex approved these changes

Assignees

@uditagarwal97 uditagarwal97

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build fails on Ubuntu 24.04 in Nightly

2 participants

@uditagarwal97 @sarnex