[SYCL] Remove HIP Nvidia tests/CI support #16611
Conversation
As noted in intel#14432 the configuration isn't supported/tested anymore and there were some PRs removing related `XFAIL`s (intel#16287, intel#16307, and possibly others). This PR goes a step further removes all the support for that configuration.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| if "amdgcn-amd-amdhsa" in triple: | ||
| llvm_config.with_system_environment("ROCM_PATH") | ||
| config.available_features.add("hip_amd") | ||
| config.available_features.add("hip") |
There was a problem hiding this comment.
Can we move this change to a separate commit or even PR?
There was a problem hiding this comment.
I don't see how, but maybe I don't fully understand the question.
There was a problem hiding this comment.
If I get it right, this change renames hip_amd lit feature into hip. The renaming makes sense to me, but it's not necessary for removing "HIP NVIDIA infrastructure support". The change contributes a significant part of changes to the diff, which will be easier to review separately.
There was a problem hiding this comment.
In practice that might be true, but in theory/semantically it's only possible after hip_nvidia removal. Also, the renaming part is only true for sycl/test while many of the changes are for sycl/test-e2e. There, it's not the renaming as hip LIT feature is pre-existing and means hip backend, which is true for both hip_nvidia and hip_amd. I can only change hip_amd->hip in tests' directives after/with the removal.
There was a problem hiding this comment.
I've updated this PR to only modify our tests. I think that is, essentially, what you've asked for.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
changed the title
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
left a comment
uditagarwal97
left a comment
There was a problem hiding this comment.
SYCL Changes LGTM.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
left a comment
AlexeySachkov
left a comment
There was a problem hiding this comment.
Changes to Printf tests LGTM
8 participants
As noted in #14432 the configuration isn't supported/tested anymore and there were some PRs removing related
XFAILs (#16287, #16307, and possibly others).This PR goes a step further and removes all the support for that configuration in our LIT tests.