Skip to content

Conversation

@ldrumm
Copy link
Contributor

@ldrumm ldrumm commented Jan 16, 2025

I changed the wording here also to cover the possibility that documentation no longer reflects reality on the next bump.

@ldrumm ldrumm requested a review from bader as a code owner January 16, 2025 14:36
@dm-vodopyanov dm-vodopyanov changed the title [SYCL][doc] Update documented clang-format version [SYCL][DOC] Update documented clang-format version Jan 16, 2025
I changed the wording here also to cover the possibility that
documentation no longer reflects reality on the next bump.
@ldrumm ldrumm force-pushed the clang-format-version-doc branch from c4a81ac to 01c87b3 Compare January 16, 2025 15:09
@dm-vodopyanov
Copy link
Contributor

@ldrumm thanks for the fix. Please also avoid force-pushing as it is harder for reviewers to track what was changed.

@ldrumm
Copy link
Contributor Author

ldrumm commented Jan 16, 2025

@ldrumm thanks for the fix. Please also avoid force-pushing as it is harder for reviewers to track what was changed.

That's a github bug, that I don't believe should force me to change my personal workflow in ldrumm - where I like to keep my patches fast-foward ready. Please reiterate the importance of fixing this bug to github if you think it's hard to review such changes.

@ldrumm
Copy link
Contributor Author

ldrumm commented Feb 4, 2025

ping

CONTRIBUTING.md Outdated
GitHub Actions check we recommend using 10 version of clang-format tool
(default version on Ubuntu 22.04).
the GitHub Actions check we recommend using the same version of clang-format
as used in the CI. See `.github/workflows/pr-code-format.yml` for the
Copy link
Contributor

@bader bader Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a link to the .github/workflows/pr-code-format.yml file would simplify navigation.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

@intel/llvm-gatekeepers please consider merging

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

@intel/llvm-gatekeepers please consider merging

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

@intel/llvm-gatekeepers please consider merging

1 similar comment
@github-actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

Co-authored-by: Nikita Kornev <[email protected]>
@github-actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

10 similar comments
@github-actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

@github-actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

@github-actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

@github-actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

@github-actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

@intel/llvm-gatekeepers please consider merging

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

@intel/llvm-gatekeepers please consider merging

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

@intel/llvm-gatekeepers please consider merging

@github-actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

@github-actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

@againull againull merged commit 5c06ef3 into intel:sycl Oct 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants