-
Notifications
You must be signed in to change notification settings - Fork 794
[SYCL][DOC] Update documented clang-format version #16660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I changed the wording here also to cover the possibility that documentation no longer reflects reality on the next bump.
c4a81ac to
01c87b3
Compare
|
@ldrumm thanks for the fix. Please also avoid force-pushing as it is harder for reviewers to track what was changed. |
That's a github bug, that I don't believe should force me to change my personal workflow in |
|
ping |
CONTRIBUTING.md
Outdated
| GitHub Actions check we recommend using 10 version of clang-format tool | ||
| (default version on Ubuntu 22.04). | ||
| the GitHub Actions check we recommend using the same version of clang-format | ||
| as used in the CI. See `.github/workflows/pr-code-format.yml` for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a link to the .github/workflows/pr-code-format.yml file would simplify navigation.
|
@intel/llvm-gatekeepers please consider merging |
1 similar comment
|
@intel/llvm-gatekeepers please consider merging |
|
@intel/llvm-gatekeepers please consider merging |
1 similar comment
|
@intel/llvm-gatekeepers please consider merging |
Co-authored-by: Nikita Kornev <[email protected]>
|
@intel/llvm-gatekeepers please consider merging |
10 similar comments
|
@intel/llvm-gatekeepers please consider merging |
|
@intel/llvm-gatekeepers please consider merging |
|
@intel/llvm-gatekeepers please consider merging |
|
@intel/llvm-gatekeepers please consider merging |
|
@intel/llvm-gatekeepers please consider merging |
|
@intel/llvm-gatekeepers please consider merging |
|
@intel/llvm-gatekeepers please consider merging |
|
@intel/llvm-gatekeepers please consider merging |
|
@intel/llvm-gatekeepers please consider merging |
|
@intel/llvm-gatekeepers please consider merging |
I changed the wording here also to cover the possibility that documentation no longer reflects reality on the next bump.