-
Notifications
You must be signed in to change notification settings - Fork 795
[Driver][SYCL] Add support for -fsyclbin #17252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds support for the -fsyclbin option. This option allows for creation of a SYCL device specific binary. The binary is created via a device compilation before being packaged and sent to the clang-linker-wrapper. The clang-linker-wrapper is responsible to take the device 'object' and create the corresponding .syclbin file.
|
Not ready for prime-time yet. The corresponding support in the |
steffenlarsen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this is great and I have tested it locally with the changes from #16873.
I do wonder if we could let -fsyclbin imply -fsycl, as I don't see there being a use-case where you wouldn't have both, but I really don't think it's a big issue either way.
Adding the implication is reasonable - similar to |
Done! |
|
@mdtoguchi - #16873 has been merged. You can, if you want, change the 3 first RUN lines in sycl/test/syclbin/simple_kernel.cpp to: // RUN: %clangxx -fsyclbin -o %t.syclbin %t.out |
maarquitos14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of nits.
|
@intel/llvm-gatekeepers, this is ready for merge. Thanks! |
Adds support for the -fsyclbin option. This option allows for creation of a SYCL device specific binary. The binary is created via a device compilation before being packaged and sent to the clang-linker-wrapper. The clang-linker-wrapper is responsible to take the device 'object' and create the corresponding .syclbin file.