-
Notifications
You must be signed in to change notification settings - Fork 795
[UR][SYCL] Add urUSMContextMemcpyExp API to enable device global support. #17268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ed70b0c to
cf7c09e
Compare
3f4ad4a to
db41224
Compare
Seanst98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CUDA changes LGTM
kbenzie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UR spec & test LGTM
pbalcer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L0 lgtm.
|
@intel/unified-runtime-reviewers-level-zero this needs a re-approval because the l0 review group was added since opening the PR |
|
@intel/llvm-reviewers-cuda looks like this needs a re-approval, the adapter changes were previously approved not sure why that review seems to have been discounted |
frasercrmck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CUDA LGTM
|
@intel/llvm-gatekeepers please merge |
Also adds a path using the new api to avoid a workaround introduced in #16565