-
Notifications
You must be signed in to change notification settings - Fork 796
[SYCL] Allocate sycl::handler on the stack when possible #17319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Allocate sycl::handler on the stack when possible #17319
Conversation
72a23fe to
7db0650
Compare
|
@againull Could you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix grammar in the PR title:
"[SYCL] Allocate sycl::handler in stack when possible" ->
"[SYCL] Allocate sycl::handler on the stack when possible"
Co-authored-by: Alexey Bader <[email protected]>
Co-authored-by: Alexey Bader <[email protected]>
Co-authored-by: Alexey Bader <[email protected]>
Co-authored-by: Alexey Bader <[email protected]>
Co-authored-by: Alexey Bader <[email protected]>
|
@intel/llvm-reviewers-runtime , Colleagues, I see ThreadSanitizer/check_usm.cpp failed for other PRs as well, and there are 2 approvals. What are possible next steps? |
I think the issue is unrelated to this PR, see #17486 |
|
|
||
| handler::handler(const std::shared_ptr<detail::queue_impl> &Queue, | ||
| bool CallerNeedsEvent) | ||
| : MImplOwner(std::make_shared<detail::handler_impl>(Queue.get(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why Queue.get() here instead of nullptr? handler_impl ctor expects secondary queue here, not primary one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, opened PR #18752 with the fix.
There are two set of changes: