Skip to content

Conversation

hvdijk
Copy link
Contributor

@hvdijk hvdijk commented Mar 12, 2025

In the libspirv builtins, no definitions of fma and ldexp are provided, and there must be no references to them. Call __spirv_ocl_fma and __spirv_ocl_ldexp instead.

In the libspirv builtins, no definitions of fma and ldexp are provided,
and there must be no references to them. Call __spirv_ocl_fma and
__spirv_ocl_ldexp instead.
@hvdijk hvdijk requested a review from a team as a code owner March 12, 2025 09:23
@hvdijk hvdijk requested a review from omarahmed1111 March 12, 2025 09:23
@hvdijk hvdijk temporarily deployed to WindowsCILock March 12, 2025 09:24 — with GitHub Actions Inactive
@hvdijk
Copy link
Contributor Author

hvdijk commented Mar 12, 2025

cc @jsji, I think this was a bad pulldown in #16781 that went unnoticed because most targets have their own exp10 definition rather than using this generic one, before that PR this file was using __spirv_ocl_* functions?

Copy link
Contributor

@frasercrmck frasercrmck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It does look like a pulldown issue. Upstream, and at the next pulldown, these will be __clc_fma and __clc_ldexp. But until then we should stick with the SPIR-V versions.

@hvdijk
Copy link
Contributor Author

hvdijk commented Mar 17, 2025

@intel/llvm-gatekeepers This is ready to be merged, thanks.

@martygrant martygrant merged commit f85999b into intel:sycl Mar 17, 2025
24 checks passed
@hvdijk hvdijk deleted the clc-exp10 branch September 4, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants