Skip to content

Conversation

@sarnex
Copy link
Contributor

@sarnex sarnex commented Mar 17, 2025

I forgot to do this when I updated the workflow to run on driver updates, so it wasn't using the new driver.

@sarnex sarnex temporarily deployed to WindowsCILock March 17, 2025 16:24 — with GitHub Actions Inactive
@sarnex sarnex changed the title [CI] Correctly set install_igc_driver and related opts in postcommit [CI] Correctly set install_igc_driver in postcommit Mar 17, 2025
@sarnex sarnex temporarily deployed to WindowsCILock March 17, 2025 16:24 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to WindowsCILock March 17, 2025 17:12 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to WindowsCILock March 17, 2025 17:16 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to WindowsCILock March 17, 2025 17:16 — with GitHub Actions Inactive
@sarnex sarnex marked this pull request as ready for review March 17, 2025 19:09
@sarnex sarnex requested a review from a team as a code owner March 17, 2025 19:09
@sarnex sarnex requested a review from aelovikov-intel March 17, 2025 19:09
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. conditional on testing push trigger before merging
  2. Should we check reset_intel_gpu instead of "hip/cuda" condition?

Signed-off-by: Sarnie, Nick <[email protected]>
@sarnex
Copy link
Contributor Author

sarnex commented Mar 17, 2025

https://github.com/intel/llvm/actions/runs/13910560813/job/38923637451 seems to skip correctly now and its correctly running here

@sarnex sarnex temporarily deployed to WindowsCILock March 17, 2025 22:11 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to WindowsCILock March 17, 2025 22:11 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to WindowsCILock March 17, 2025 22:36 — with GitHub Actions Inactive
@sarnex sarnex merged commit ae74e38 into intel:sycl Mar 18, 2025
34 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants