Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
name: Benchmarks

# This workflow is a WIP: this workflow file acts as a placeholder.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we be using this file for the unified compute-benchmark workflow? If so, I'd prefer renaming it to sycl-perf-benchmarking or something similar with the sycl- prefix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be running test suites the UR people wanted as well, that's why I was hesitant on adding a sycl- prefix

...that being said, any better name ideas that don't exclude UR? 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be running test suites the UR people wanted as well, that's why I was hesitant on adding a sycl- prefix

sycl-ur-perf-benchmarking? All of our home-grown workflows have sycl or ur prefixes to distinguish them from the workflows in upstream LLVM. That's the naming scheme I want the benchmarking workflow to follow as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone ahead and renamed it, but @pbalcer let me know if you've any opinions on how you want this named

Copy link
Contributor

@pbalcer pbalcer Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be distinguishing between sycl and ur in this case. So I'm in favor of just dropping the prefix. Or, if we need one, I'd just stick with sycl-, it's the most general one.


on: [ workflow_dispatch ]

jobs:
do-nothing:
runs-on: ubuntu-latest
steps:
- run: echo 'This workflow is a WIP.'

2 changes: 2 additions & 0 deletions .github/workflows/ur-benchmarks-reusable.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
name: Benchmarks Reusable

# This workflow is a WIP: This workflow file acts as a placeholder.
#
# This workflow is set to be merged into benchmark.yml

on: [ workflow_call ]

Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/ur-benchmarks.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
name: Benchmarks

# This workflow is a WIP: this workflow file acts as a placeholder.
#
# This workflow is set to be merged into benchmark.yml

on: [ workflow_dispatch ]

Expand Down
Loading