Skip to content

Conversation

@kswiecicki
Copy link
Contributor

Add extension to ur_usm_pool_desc_t structure chain that allows the user to specify a buffer and its size that should by used for pool creation in urUSMPoolCreate or urUSMPoolCreateEx function.

@kswiecicki
Copy link
Contributor Author

This extension is supposed to satisfy the SYCL async API requirement, allowing users to create a pool from a USM pointer obtained via urUSM[Host|Device|Shared]Alloc or urEnqueueUSM[Host|Device|Shared]AllocExp functions.
@Seanst98 could you take a look?

@kswiecicki
Copy link
Contributor Author

Hey @Seanst98 could you plase check whether the review fixes are acceptable?

Copy link
Contributor

@Seanst98 Seanst98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add your changes to the associated EXP-ASYNC-ALLOC.rst and update the changelog.

@kswiecicki kswiecicki changed the title [UR] Add ur_usm_pool_native_desc_t extension [UR] Add ur_usm_pool_buffer_desc_t extension Apr 1, 2025
@kswiecicki
Copy link
Contributor Author

Can you also add your changes to the associated EXP-ASYNC-ALLOC.rst and update the changelog.

Done. I've updated the Types section and the changelog.

Copy link
Contributor

@Seanst98 Seanst98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add yourself as a contributor in the .rst 😄. Otherwise, LGTM!

Add extension to ur_usm_pool_desc_t structure chain that allows the user
to specify a buffer and its size that should by used for pool creation
in urUSMPoolCreate or urUSMPoolCreateExp function.
@kswiecicki
Copy link
Contributor Author

@intel/llvm-gatekeepers, someone merge this PR please.

@kbenzie kbenzie merged commit acf9907 into intel:sycl Apr 8, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants