-
Notifications
You must be signed in to change notification settings - Fork 796
[UR] Add ur_usm_pool_buffer_desc_t extension #17634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ac2134a to
cb5af01
Compare
|
This extension is supposed to satisfy the SYCL async API requirement, allowing users to create a pool from a USM pointer obtained via |
cb5af01 to
90445ca
Compare
90445ca to
36d5d95
Compare
|
Hey @Seanst98 could you plase check whether the review fixes are acceptable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add your changes to the associated EXP-ASYNC-ALLOC.rst and update the changelog.
36d5d95 to
16a3902
Compare
Done. I've updated the |
16a3902 to
8dcb7cc
Compare
8dcb7cc to
510e8c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add yourself as a contributor in the .rst 😄. Otherwise, LGTM!
510e8c9 to
ff0b27f
Compare
ff0b27f to
aff3b05
Compare
aff3b05 to
8e41744
Compare
8e41744 to
3f92248
Compare
Add extension to ur_usm_pool_desc_t structure chain that allows the user to specify a buffer and its size that should by used for pool creation in urUSMPoolCreate or urUSMPoolCreateExp function.
|
@intel/llvm-gatekeepers, someone merge this PR please. |
Add extension to ur_usm_pool_desc_t structure chain that allows the user to specify a buffer and its size that should by used for pool creation in urUSMPoolCreate or urUSMPoolCreateEx function.