[SYCL][E2E] Fix interop_all_backends for CUDA #17643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CUDA backend has two different versions of the interop. A legacy version and a newer experimental version. Using the experimental version requires defining a macro before including the SYCL headers. This test uses the experimental version so it should define the macro.
npmiller
force-pushed
the
fix-cuda-interop-all
branch
from
2634102 to
bdb6997
Compare
Contributor
Author
|
friendly ping @intel/llvm-reviewers-runtime @slawekptak |
Contributor
Author
|
@intel/llvm-reviewers-runtime @slawekptak could I get a review on this, it's a very small test update |
slawekptak
reviewed
Apr 9, 2025
| // XFAIL: target-nvidia | ||
| // XFAIL-TRACKER: https://github.com/intel/llvm/issues/16070 | ||
| // RUN: %if target-spir %{ %{build} -o %t-opencl.out %} | ||
| // RUN: %if target-nvidia %{ %{build} -isystem %sycl_include -DBUILD_FOR_CUDA -o %t-cuda.out %} |
Contributor
There was a problem hiding this comment.
Just to make sure, was the -isystem option removed intentionally?
Contributor
Author
There was a problem hiding this comment.
Yes, it's unnecessary, not sure why it was added in the first place, when it was added the test was already xfaild
slawekptak
approved these changes
Apr 9, 2025
Contributor
Author
|
@intel/llvm-gatekeepers this is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CUDA backend has two different versions of the interop. A legacy version and a newer experimental version. Using the experimental version requires defining a macro before including the SYCL headers. This test uses the experimental version so it should define the macro.
Fixes: #16070