Skip to content

[SYCL][UR] Log sycl-ls adapter errors in verbose mode #17651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

[SYCL][UR] Log sycl-ls adapter errors in verbose mode #17651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions sycl/tools/sycl-ls/sycl-ls.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,21 +364,21 @@ int main(int argc, char **argv) {
if (DiscardFilters && FilterEnvVars.size())
unsetFilterEnvVars();

// Store the original UR_LOG_LOADER environment variable and enable printing
// of any errors related to adapter loading.
const char *orig_ur_log_loader_var = std::getenv("UR_LOG_LOADER");
std::string orig_ur_log_loader_var_str;
if (orig_ur_log_loader_var != NULL)
orig_ur_log_loader_var_str.assign(orig_ur_log_loader_var);

setenv("UR_LOG_LOADER", "level:error;output:stderr", 1);
// In verbose mode, if UR logging has not already been enabled by the user,
// enable the printing of any errors related to adapter loading.
const char *ur_log_loader_var = std::getenv("UR_LOG_LOADER");
if (verbose && ur_log_loader_var == nullptr)
setenv("UR_LOG_LOADER", "level:info;output:stderr", 1);

const auto &Platforms = platform::get_platforms();

if (orig_ur_log_loader_var == NULL)
if (verbose && ur_log_loader_var == nullptr) {
unsetenv("UR_LOG_LOADER");
else
setenv("UR_LOG_LOADER", orig_ur_log_loader_var_str.c_str(), 1);
} else if (Platforms.size() == 0) {
std::cout
<< "No platforms found - run with '--verbose' to get more details."
<< std::endl;
}

// Keep track of the number of devices per backend
std::map<backend, size_t> DeviceNums;
Expand Down
2 changes: 1 addition & 1 deletion unified-runtime/source/common/linux/ur_lib_loader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ LibLoader::loadAdapterLibrary(const char *name) {
(strstr(err, name) == NULL || strstr(err, "required by") != NULL)) {
// If the adapter cannot be loaded due to missing dependencies or any
// other related error, it is considered as an error.
logger::error("failed to load adapter '{}' with error: {}", name, err);
logger::info("failed to load adapter '{}' with error: {}", name, err);
} else {
// Simply having the adapter library missing isn't an error.
logger::info("failed to load adapter '{}' with error: {}", name,
Expand Down
Loading