Skip to content

Conversation

@JackAKirk
Copy link
Contributor

image_get_info.cpp previously comprised three types of tests which have been split into separate test files

  • testing queries of a oneapi::experimental::image_mem instance (image_get_info.cpp)
  • testing device queries for image requirements (either max image dimensions or pitch alignment) (image_reqs_get_info.cpp)
  • testing device queries for bindless images aspects (bindless_aspects.cpp)

This PR splits up these tests which is useful for diagnosing problems on different backends:

  • image_get_info.cpp is currently only unsupported on the HIP backend (Known issue)
  • image_reqs_get_info.cpp is currently only unsupported on the L0 backend [BINDLESS][L0] Fix image requirement queries on L0 in driver/UR #17663
  • bindless_aspects.cpp has been fixed on L0 backend so it now passes on all backends, by only querying mipmap_max_anisotropy if aspect::ext_oneapi_mipmap_anisotropy returns true

@JackAKirk JackAKirk marked this pull request as ready for review March 27, 2025 08:06
@JackAKirk JackAKirk requested a review from a team as a code owner March 27, 2025 08:06
@JackAKirk
Copy link
Contributor Author

@intel/llvm-gatekeepers

This is ready to be merged. Thanks!

@martygrant martygrant merged commit 090a353 into intel:sycl Apr 4, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants