[UR] Make ONEAPI_DEVICE_SELECTOR prefilter test pass #17667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@nrspruit Can you have a quick look at the testing changes? I've updated the tests to be more inline with the format expected in Oneapi itself. |
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
force-pushed
the
ross/prefilter
branch
from
3ec7862 to
e477f74
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@nrspruit Mind having a look at this when you get the chance? |
Contributor
Author
|
@nrspruit Can you look at this? |
The prefilter.cpp test was failing, this fixes it as follows: * Strings that can't be parsed are now treated as `*:*` rather than `!*:*`. * Backend names are validated; any invalid ones cause the entire string to be rejected. * In ur_lib.cpp, the parser is updated to handle failing to parse the string (doesn't affect the test, but a nice to have). * Some selector strings in the test itself were invalid and updated. This was done according to the specification of ONEAPI_DEVICE_SELECTOR located at https://github.com/intel/llvm/blob/sycl/sycl/doc/EnvironmentVariables.md#oneapi_device_selector . These changes also meant fixing the urDeviceGetSelected.cpp conformance test, since we now return `INVALID_VALUE` rather than `UNKNOWN`.
RossBrunton
force-pushed
the
ross/prefilter
branch
from
e477f74 to
6f94968
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
nrspruit
approved these changes
Apr 23, 2025
Contributor
nrspruit
left a comment
nrspruit
left a comment
There was a problem hiding this comment.
LGTM, sorry for the delay
Contributor
Author
|
@intel/llvm-gatekeepers Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prefilter.cpp test was failing, this fixes it as follows:
*:*rather than!*:*.to be rejected.
string (doesn't affect the test, but a nice to have).
This was done according to the specification of ONEAPI_DEVICE_SELECTOR
located at https://github.com/intel/llvm/blob/sycl/sycl/doc/EnvironmentVariables.md#oneapi_device_selector .