Revert "[UR] Replace calls to UR in native handle functions to proper OpenCL functions (#17016)" #17680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… OpenCL functions (intel#17016)" This reverts commit e1cf106. In testing, it turns out a number of people link against `libOpenCL.so.1` rather than `libOpenCL.so`, which is considered a seperate library by the linker. Reverting this change for now while we consider the best option.
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
approved these changes
Mar 27, 2025
Contributor
Author
|
https://github.com/intel/llvm/pull/17708/files Hopefully the root issue should be fixed by this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e1cf106.
In testing, it turns out a number of people link against
libOpenCL.so.1rather thanlibOpenCL.so, which is considereda seperate library by the linker. Reverting this change for now
while we consider the best option.