[UR] Fixed bug with zero depth ur_rect_region which must be checked before calling func #17681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GermanAizek
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
changed the title
GermanAizek
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
GermanAizek
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
|
looks like there're more files the change needs propagating to, the easiest way is to run the |
Fixed functions: - urEnqueueMemBufferWriteRect() - urEnqueueMemBufferReadRect()
Contributor
Author
|
@aarongreig, I fixed all conditions and renamed commit name. |
GermanAizek
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
GermanAizek
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
GermanAizek
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
approved these changes
Mar 31, 2025
RossBrunton
approved these changes
Mar 31, 2025
Contributor
|
@GermanAizek it looks like the CI had some issues last week, would you mind updating the branch so it re-runs it against the latest changes? Other than that it should be good to merge, thanks for the patch! |
Contributor
|
@intel/llvm-gatekeepers this is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its PR migrated from oneapi-src/unified-runtime#2746
It looks like a common typo when writing functions.
Fixed functions: