[SYCL][AsyncAlloc] Fix minor async alloc issues #17689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a couple static analysis issues with the recent async alloc patch: * Use `std::move` for shared pointer in `CGAsyncAlloc` constructor. It is already passed by-value to the constructor so we can just move it when assigning it to the member. * Assert that the queue is available in `AsyncFree` * Catch any exceptions from the memory pool destructor * Initialize AsyncAlloc fields in handler
npmiller
force-pushed
the
async-alloc-fixes
branch
from
54e2144 to
4b9e691
Compare
againull
approved these changes
Mar 28, 2025
HPS-1
approved these changes
Mar 30, 2025
Contributor
Author
|
@intel/llvm-gatekeepers this should be ready to merge, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a couple static analysis issues with the recent async alloc patch:
std::movefor shared pointer inCGAsyncAllocconstructor. It is already passed by-value to the constructor so we can just move it when assigning it to the member.AsyncFree[[maybe_unused]]for parameter only used in assert