[SYCL][E2E] Add LIT feature for HIP #17692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
sarnex
requested review from
EwanC,
KornevNikita,
aelovikov-intel and
uditagarwal97
sarnex
changed the title
|
|
||
| with test_env(): | ||
| sp = subprocess.getstatusoutput( | ||
| config.dpcpp_compiler + " -fsycl " + check_hip_file + hip_options |
Contributor
There was a problem hiding this comment.
Do we need -fsycl here?
Contributor
Author
There was a problem hiding this comment.
probably not but i just copied what we did for cuda, i can remove it from both if you think thats better
Contributor
There was a problem hiding this comment.
No difference to me at all.
aelovikov-intel
approved these changes
Mar 28, 2025
EwanC
approved these changes
Mar 28, 2025
KornevNikita
approved these changes
Mar 28, 2025
Contributor
KornevNikita
left a comment
KornevNikita
left a comment
There was a problem hiding this comment.
I don't insist on adding this, but we could test `REQUIRES: hip_dev_kit" by replacing this one (I already have a draft PR to update this, so you can ignore me):
uditagarwal97
approved these changes
Mar 28, 2025
Contributor
Author
|
@KornevNikita Yeah I'm still fighting with the Windows runners to get it actually working, once it does I'll let you know and please edit that test :) |
sarnex
pushed a commit
that referenced
this pull request
May 15, 2025
For ROCm installations that aren't just in `/opt/rocm`, `clang` uses `ROCM_PATH` at runtime to find the ROCm device libraries, and this is done even in regular SYCL compilation. So this is needed for lit tests in certain configurations. This was accidentally removed in #17692 it doesn't cause any issues in the CI because the CI has ROCm installed in the standard `/opt/rocm`, but it causes issues on local setups. Also remove `--rocm-path` on Windows, this should be covered by `ROCM_PATH`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have features for Level Zero and CUDA, add one for HIP.