[UR][CUDA] Use different throttle reasons API based on CUDA version #17719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our pre-commit CI uses CUDA 12.6 but nightly uses CUDA 12.1, it turns out nvml which is part of CUDA 12.6 has nvmlDeviceGetCurrentClocksEventReasons API, but nvml which is part of CUDA 12.1 doesn't have it, but only supports older deprecated nvmlDeviceGetCurrentClocksThrottleReasons. NVML doesn't provide a version macro to check the support for that API, so use new API nvmlDeviceGetCurrentClocksEventReasons based on cuda version.
npmiller
approved these changes
Mar 31, 2025
Contributor
Author
|
Jenkins/Precommit failure is unrelated and visible in other PRs. |
KornevNikita
pushed a commit
that referenced
this pull request
Jun 4, 2025
…17719) Our pre-commit CI uses CUDA 12.6 but nightly uses CUDA 12.1, it turns out nvml which is part of CUDA 12.6 has nvmlDeviceGetCurrentClocksEventReasons API, but nvml which is part of CUDA 12.1 doesn't have it, but only supports older deprecated nvmlDeviceGetCurrentClocksThrottleReasons. NVML doesn't provide a version macro to check the support for that API, so use new API nvmlDeviceGetCurrentClocksEventReasons based on cuda version.
KornevNikita
pushed a commit
that referenced
this pull request
Jun 12, 2025
…17719) Our pre-commit CI uses CUDA 12.6 but nightly uses CUDA 12.1, it turns out nvml which is part of CUDA 12.6 has nvmlDeviceGetCurrentClocksEventReasons API, but nvml which is part of CUDA 12.1 doesn't have it, but only supports older deprecated nvmlDeviceGetCurrentClocksThrottleReasons. NVML doesn't provide a version macro to check the support for that API, so use new API nvmlDeviceGetCurrentClocksEventReasons based on cuda version.
AlexeySachkov
pushed a commit
that referenced
this pull request
Jun 18, 2025
Cherry-pick commits that reached the internal branch between intel/llvm cutoff and release branch pulldown. Patches included: --- [SYCL][Doc] Add new device descriptors to sycl_ext_intel_device_info extension (#17386) Patch-by: Artur Gainullin <[email protected]> --- [SYCL][CUDA] Add implementation of new device descriptors (#17590) Tests were not added because there are existing conformance tests which cover this functionality. Patch-by: Artur Gainullin <[email protected]> --- [UR][CUDA] Use different throttle reasons API based on CUDA version (#17719) Our pre-commit CI uses CUDA 12.6 but nightly uses CUDA 12.1, it turns out nvml which is part of CUDA 12.6 has nvmlDeviceGetCurrentClocksEventReasons API, but nvml which is part of CUDA 12.1 doesn't have it, but only supports older deprecated nvmlDeviceGetCurrentClocksThrottleReasons. NVML doesn't provide a version macro to check the support for that API, so use new API nvmlDeviceGetCurrentClocksEventReasons based on cuda version. Patch-by: Artur Gainullin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our pre-commit CI uses CUDA 12.6 but nightly uses CUDA 12.1, it turns out nvml which is part of CUDA 12.6 has nvmlDeviceGetCurrentClocksEventReasons API, but nvml which is part of CUDA 12.1 doesn't have it, but only supports older deprecated nvmlDeviceGetCurrentClocksThrottleReasons.
NVML doesn't provide a version macro to check the support for that API, so use new API nvmlDeviceGetCurrentClocksEventReasons based on cuda version.