[NFC][SYCL] Don't emit OpenCL metadata for SYCL #17723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
commented
Mar 28, 2025
bader
commented
Mar 28, 2025
bader
commented
Mar 28, 2025
bader
commented
Mar 28, 2025
tahonermann
added a commit
to tahonermann/llvm-project
that referenced
this pull request
Mar 28, 2025
…rnels. Elizabeth's changes to perform code generation for SYCL kernel device entry point functions caused the following kernel metadata annotations to be emitted for all device targets. - `kernel_arg_addr_space` - `kernel_arg_access_qual` - `kernel_arg_type` - `kernel_arg_base_type` - `kernel_arg_type_qual` It turns out that such metadata is not needed for SYCL; the above annotations are only needed for OpenCL. Investigation revealed that these annotations are emitted by the oneAPI compiler for ESIMD functions, but that was apparently due to an incorrect merge conflict resolution that is now being addressed by intel/llvm#17723. The above annotations are referenced by the SPIR-V Translator documentation. See https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/main/docs/SPIRVRepresentationInLLVM.rst#function-metadata. The oneAPI compiler does emit a `kernel_arg_buffer_location` annotation that is presumed to be needed as part of the support for the dead kernel argument elimination pass. Support for that annotation does not yet exist upstream.
bader
commented
Mar 28, 2025
|
|
||
| // CHECK: define dso_local spir_kernel {{.*}} !kernel_arg_addr_space ![[#MD:]] | ||
| // CHECK: !kernel_arg_access_qual ![[#MD]] !kernel_arg_type ![[#MD]] !kernel_arg_base_type ![[#MD]] !kernel_arg_type_qual ![[#MD]] !kernel_arg_accessor_ptr ![[#MD]] | ||
| // CHECK: define dso_local spir_kernel {{.*}} !sycl_kernel_omit_args ![[#MD:]] |
Contributor
Author
There was a problem hiding this comment.
@intel/dpcpp-esimd-reviewers, I'm sure I understand the purpose of this test, but I tried to check that "dead argument elimination" optimization attaches metadata correctly.
It looks like original test verifies that other metadata do not refer to deleted argument. Should I check for !kernel_arg_accessor_ptr?
I removed it because "dead argument elimination" should not change the value of this metadata. It will be empty in any case.
Contributor
Author
|
CI results analysis: SYCL Pre Commit on Windows / build / Build + LIT (pull_request) Jenkins/Precommit |
sarnex
approved these changes
Mar 31, 2025
Contributor
Author
|
@intel/dpcpp-cfe-reviewers, ping. |
Fznamznon
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kernel_arg_addr_space,kernel_arg_access_qual,kernel_arg_type,kernel_arg_base_typeandkernel_arg_type_qualmetadata are designed to provide information about kernel arguments to clGetKernelInfo function.SYCL does not provide similar information through API.