[NFCI][SYCL] Remove srcloc metadata before sycl-post-link

[MrSidims]

It's no longer needed after SYCLPropagateAspectsUsage pass.

[steffenlarsen]

SYCL test changes LGTM.

[maarquitos14]

LGTM.

[bader]

Thanks!

[MrSidims]

@intel/llvm-gatekeepers I think we can merge the patch.

[aelovikov-intel]

Is NFC tag usage aligned with LLVM programming guide here?

[MrSidims]

Is NFC tag usage aligned with LLVM programming guide here?

@aelovikov-intel I'm not sure if LLVM programming guide defines NFC. I appreciate if you provide a quote from it with the definition, so I could evaluate if the PR is NFC from LLVM programming guide's stand point.

[aelovikov-intel]

Not an official doc, but from this thread (https://discourse.llvm.org/t/nfc-abuse/58479/24):

That’s my litmus test: I see NFC is an indication that no test changes and none are expected to be provided.

[MrSidims]

Not an official doc, but from this thread (https://discourse.llvm.org/t/nfc-abuse/58479/24):

@aelovikov-intel should we formalize the definition and add it in documentation at least for https://github.com/intel/llvm ?

[aelovikov-intel]

Not an official doc, but from this thread (https://discourse.llvm.org/t/nfc-abuse/58479/24):

@aelovikov-intel should we formalize the definition and add it in documentation at least for https://github.com/intel/llvm ?

Up to you, I've just highlighted a possible confusion. If you think current title is fine, I don't mind.

[MrSidims]

Updated the tag to NFCI

[bader]

Updated the tag to NFCI

@aelovikov-intel, please, merge PR if you have no other comments.