-
Notifications
You must be signed in to change notification settings - Fork 796
[UR] Added "roundtrip" GetInfo comformance tests #17738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d8bdbb to
f302f7c
Compare
f302f7c to
a78a0e6
Compare
a78a0e6 to
08dce95
Compare
08dce95 to
feca1c6
Compare
feca1c6 to
7e647e3
Compare
7e647e3 to
56faf07
Compare
56faf07 to
46be395
Compare
46be395 to
18ace56
Compare
This tests that converting a UR handle to a native handle, then back into a UR handle preserves/recreates any handles contained within it. The event test is a special case; since urEventCreateWithNativeHandle doesn't accept a queue paramater. For this, we tollerate a different queue being created, as long as they both have the same underlying native handle.
18ace56 to
23afb50
Compare
aarongreig
reviewed
Apr 3, 2025
aarongreig
approved these changes
Apr 4, 2025
Contributor
Author
|
@intel/llvm-gatekeepers Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests that converting a UR handle to a native handle, then back
into a UR handle preserves/recreates any handles contained within it.
The event test is a special case; since urEventCreateWithNativeHandle
doesn't accept a queue paramater. For this, we tollerate a different
queue being created, as long as they both have the same underlying
native handle.