[UR] Improve testing for gfx1100 on OpenCL #17747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
reviewed
Apr 1, 2025
unified-runtime/test/conformance/testing/include/uur/fixtures.h
Outdated
Show resolved
Hide resolved
RossBrunton
force-pushed
the
ross/gfx1100
branch
from
1b5816c to
550f9b9
Compare
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
RossBrunton
force-pushed
the
ross/gfx1100
branch
from
550f9b9 to
ae738a1
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
The driver I have at least has a number of issues, the largest of which is that it lacks an IR compiler. Amongst other tests, this also blacklists gfx1100 on OpenCL from any test that requires the compiler.
RossBrunton
force-pushed
the
ross/gfx1100
branch
from
ae738a1 to
0685346
Compare
aarongreig
approved these changes
Apr 4, 2025
Contributor
Author
|
@intel/sycl-graphs-reviewers Mind having a quick look at this? It just adds a bit of tolerance for backends which don't support an IR compiler. |
EwanC
approved these changes
Apr 4, 2025
Contributor
Author
|
@intel/llvm-gatekeepers Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver I have at least has a number of issues, the largest of which
is that it lacks an IR compiler. This updates tests so that they are
skipped if required.