Skip to content

Conversation

@aelovikov-intel
Copy link
Contributor

I've looked through logs of some recent pre-commit jobs (both Lin/Win) and the only test that was longer than 5 min on just some occasions is KernelCompiler/sycl.cpp. I talked to Chris and he'll upload a change to reduce its time soon. The rest seemed to be comfortably under 5 minutes, so set per-test timeout to that value in run-only mode.

I've looked through logs of some recent pre-commit jobs (both Lin/Win)
and the only test that was longer than 5 min on just some occasions is
`KernelCompiler/sycl.cpp`. I talked to Chris and he'll upload a change
to reduce its time soon. The rest seemed to be comfortably under 5
minutes, so set per-test timeout to that value in run-only mode.
@aelovikov-intel aelovikov-intel requested a review from a team as a code owner March 31, 2025 22:27
@uditagarwal97
Copy link
Contributor

is KernelCompiler/sycl.cpp. I talked to Chris and he'll upload a change to reduce its time soon

LGTM. But, shouldn't we wait for Chris to make the change in KernelCompiler/sycl.cpp first, before proceeding with this PR?

@aelovikov-intel
Copy link
Contributor Author

is KernelCompiler/sycl.cpp. I talked to Chris and he'll upload a change to reduce its time soon

LGTM. But, shouldn't we wait for Chris to make the change in KernelCompiler/sycl.cpp first, before proceeding with this PR?

#17759 and it's not like it goes that long that often.

@aelovikov-intel aelovikov-intel merged commit e690537 into sycl Apr 1, 2025
34 of 35 checks passed
@aelovikov-intel aelovikov-intel deleted the test-timeout branch April 1, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants