Skip to content

Conversation

@KornevNikita
Copy link
Contributor

This patch adds a step to conditionally pack pure sycl-toolchain for release.

This patch adds a step to conditionally pack pure sycl-toolchain for
release.
@KornevNikita KornevNikita marked this pull request as ready for review April 1, 2025 17:29
@KornevNikita KornevNikita requested a review from a team as a code owner April 1, 2025 17:29
@KornevNikita
Copy link
Contributor Author

@KornevNikita
Copy link
Contributor Author

@AlexeySachkov FYI

- name: Pack toolchain release
if: ${{ always() && !cancelled() && steps.build.conclusion == 'success' && inputs.pack_release == 'true' }}
run: tar -I '${{ steps.artifact_info.outputs.COMPRESS }}' -cf ${{ steps.artifact_info.outputs.ARCHIVE_NAME }} -C $GITHUB_WORKSPACE/build/install .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this different from the archive created in Pack toolchain on line 238/261?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main difference is lack of extra tools that are only used in testing - they are being built and deployed on lines 246-253

Going forward, we would like to release binaries and for that we would like to minimize our release package by at least dropping internal testing tools.

Of course, the current approach isn't exactly the most efficient, because it effectively bundles the SYCL RT twice into artifacts, but that's a start, it will be improved later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how :)
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this only for sycl-rel or will we be releasing the new no-tools package from the sycl branch too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's only for sycl-rel. There is inputs.pach_release to trigger this step

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just preserved it during the refactoring, it was there long before me :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it's time to eliminate it:)) I'll create a PR.

Anyway, @sarnex @aelovikov-intel, can we merge this one and then refactor the workflow file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarnex @aelovikov-intel gentle friendly soft ping

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine, but I think @sarnex was the one objecting, so let's wait for him to confirm he's ok.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah its fine

@sarnex sarnex merged commit 37916ce into sycl Apr 4, 2025
28 checks passed
@bader bader deleted the pure-sycl-toolchain branch April 4, 2025 22:44
KornevNikita added a commit that referenced this pull request Apr 10, 2025
sarnex pushed a commit that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants