-
Notifications
You must be signed in to change notification settings - Fork 796
[CI] Pack release build #17781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Pack release build #17781
Conversation
This patch adds a step to conditionally pack pure sycl-toolchain for release.
|
@AlexeySachkov FYI |
| - name: Pack toolchain release | ||
| if: ${{ always() && !cancelled() && steps.build.conclusion == 'success' && inputs.pack_release == 'true' }} | ||
| run: tar -I '${{ steps.artifact_info.outputs.COMPRESS }}' -cf ${{ steps.artifact_info.outputs.ARCHIVE_NAME }} -C $GITHUB_WORKSPACE/build/install . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is this different from the archive created in Pack toolchain on line 238/261?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main difference is lack of extra tools that are only used in testing - they are being built and deployed on lines 246-253
Going forward, we would like to release binaries and for that we would like to minimize our release package by at least dropping internal testing tools.
Of course, the current approach isn't exactly the most efficient, because it effectively bundles the SYCL RT twice into artifacts, but that's a start, it will be improved later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this only for sycl-rel or will we be releasing the new no-tools package from the sycl branch too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's only for sycl-rel. There is inputs.pach_release to trigger this step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just preserved it during the refactoring, it was there long before me :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then it's time to eliminate it:)) I'll create a PR.
Anyway, @sarnex @aelovikov-intel, can we merge this one and then refactor the workflow file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarnex @aelovikov-intel gentle friendly soft ping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine, but I think @sarnex was the one objecting, so let's wait for him to confirm he's ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah its fine

This patch adds a step to conditionally pack pure sycl-toolchain for release.