Skip to content

Conversation

pbalcer
Copy link
Contributor

@pbalcer pbalcer commented Apr 2, 2025

Meaning 'SubmitKernel' benchmarks are now grouped into: "SubmitKernel In Order", "SubmitKernel Out of Order" + "With Completion" variants.

@pbalcer pbalcer requested a review from a team as a code owner April 2, 2025 10:14
@pbalcer pbalcer temporarily deployed to WindowsCILock April 2, 2025 10:15 — with GitHub Actions Inactive
@pbalcer
Copy link
Contributor Author

pbalcer commented Apr 2, 2025

This is re-landing this change: 6a987f7 (I realized the metadata changes is unnecessary since the dashboard scripts use the metadata name as a suffix).

@intel/llvm-reviewers-benchmarking this needs to be merged today, before the next nightly. Otherwise we will need to manually rename/remove the nightly results, since they would contain duplicate the SubmitKernel groups.

Meaning 'SubmitKernel' benchmarks are now grouped into:
"SubmitKernel In Order", "SubmitKernel Out of Order" + "With
Completion" variants.
@pbalcer
Copy link
Contributor Author

pbalcer commented Apr 2, 2025

The failures are unrelated, the runners appear to be broken:

default_selector()      : No device of requested type available.
accelerator_selector()  : No device of requested type available.
cpu_selector()          : No device of requested type available.
gpu_selector()          : No device of requested type available.
custom_selector(gpu)    : No device of requested type available.
custom_selector(cpu)    : No device of requested type available.
custom_selector(acc)    : No device of requested type available.
Error: The action has timed out.

I don't think there's much point in re-running them, since this isn't touching anything these tests use.

@intel/llvm-gatekeepers please merge

@sarnex
Copy link
Contributor

sarnex commented Apr 2, 2025

yeah i gotta investigate it

@sarnex sarnex merged commit c237313 into intel:sycl Apr 2, 2025
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants