Skip to content

Conversation

@slawekptak
Copy link
Contributor

No description provided.

@slawekptak slawekptak marked this pull request as ready for review April 3, 2025 07:13
@slawekptak slawekptak requested a review from a team as a code owner April 3, 2025 07:13
Copy link
Contributor

@vinser52 vinser52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change impact the performance?

@slawekptak
Copy link
Contributor Author

Does this change impact the performance?

This change should reduce the shared_ptr copies on the fast path by 2, right? I haven't measured this one, but this is one of the changes in the series of shared_ptr optimizations, so I would expect that overall the performance should be better.

@vinser52
Copy link
Contributor

vinser52 commented Apr 4, 2025

Does this change impact the performance?

This change should reduce the shared_ptr copies on the fast path by 2, right? I haven't measured this one, but this is one of the changes in the series of shared_ptr optimizations, so I would expect that overall the performance should be better.

Thank you! That was exactly my question: if this change impacts the hot path.

Copy link
Contributor

@KseniyaTikhomirova KseniyaTikhomirova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slawekptak slawekptak marked this pull request as draft April 7, 2025 11:27
@slawekptak slawekptak marked this pull request as ready for review April 7, 2025 12:14
@uditagarwal97 uditagarwal97 merged commit 4c22448 into intel:sycl Apr 8, 2025
36 of 37 checks passed
@slawekptak
Copy link
Contributor Author

Does this change impact the performance?

This change should reduce the shared_ptr copies on the fast path by 2, right? I haven't measured this one, but this is one of the changes in the series of shared_ptr optimizations, so I would expect that overall the performance should be better.

Thank you! That was exactly my question: if this change impacts the hot path.

Just to clarify - this affects the cache insertion flow, so once in a stable state, it seems like it doesn't affect the fast path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants