[UR] Add reference counting and ext. fn cache to OpenCL adapters #17854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
force-pushed
the
ross/noadapter
branch
from
d2465d7 to
b95b188
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
reviewed
Apr 4, 2025
RossBrunton
force-pushed
the
ross/noadapter
branch
from
b95b188 to
0b65955
Compare
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
RossBrunton
force-pushed
the
ross/noadapter
branch
from
0b65955 to
7f6f869
Compare
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
RossBrunton
changed the title
RossBrunton
force-pushed
the
ross/noadapter
branch
from
7f6f869 to
ab612c2
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
reviewed
Apr 4, 2025
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
force-pushed
the
ross/noadapter
branch
from
ab612c2 to
f8e7719
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Rather than using atexit handles to drop the adapter (which causes ordering issues with SYCL atexit handlers), `urAdapterRetain/Release` now update a reference counter. When the last adapter handle is Released, the adapter is dropped. Since it is now simple to do so, the function cache has been moved to be a member of the adapter itself rather than being a separate global.
RossBrunton
force-pushed
the
ross/noadapter
branch
from
f8e7719 to
fc13476
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
reviewed
Apr 10, 2025
aarongreig
approved these changes
Apr 10, 2025
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
approved these changes
Apr 11, 2025
|
@intel/llvm-gatekeepers Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using atexit handles to drop the adapter (which causes ordering issues with SYCL atexit handlers),
urAdapterRetain/Releasenow update a reference counter. When the last adapter handle is Released, the adapter is dropped.Since it is now simple to do so, the function cache has been moved to be a member of the adapter itself rather than being a separate global.